Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix txpool unit tests #1429

Merged
merged 3 commits into from
Apr 25, 2023
Merged

Fix txpool unit tests #1429

merged 3 commits into from
Apr 25, 2023

Conversation

Stefan-Ethernal
Copy link
Collaborator

Description

This PR fixes tx pool unit tests, because of recently introduced validation in #1120 which prevents adding dynamic fee transactions if London hard fork is not enabled.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@Stefan-Ethernal
Enable all forks at genesis and add unit test which checks that dynam…
30e511d 
…ic fee tx gets rejected if london hardfork is not enabled
@Stefan-Ethernal Stefan-Ethernal requested review from begmaroman and a team April 25, 2023 12:30
@Stefan-Ethernal Stefan-Ethernal merged commit dca3824 into develop Apr 25, 2023
@Stefan-Ethernal Stefan-Ethernal deleted the fix/txpool-unit-test-london-eip-1559 branch April 25, 2023 13:25
@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Nemanja0x Nemanja0x Nemanja0x approved these changes

@begmaroman begmaroman begmaroman approved these changes

@igorcrevar igorcrevar igorcrevar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Stefan-Ethernal @igorcrevar @begmaroman @Nemanja0x