Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVM-568 Increase MaxBlockBacklog for block tracker #1347

Merged
merged 2 commits into from
Mar 31, 2023

Conversation

igorcrevar
Copy link
Contributor

@igorcrevar igorcrevar commented Mar 30, 2023

Description

Part of the event tracker is the block tracker, which fetches blocks from provided JSON RPC endpoint. In order to determine if there are reorgs happening, there is a MaxBlockBacklog parameter. It turned out that default value of 10 blocks is not big enough.

The solution proposal is to initialize the MaxBlockBacklog parameter as 2*NumBlockConfirmations (or consider putting even more).

BlockTracker creation/initialization is moved to tracker/event_tracker.go. That way we have much more options when configuring blocktracker

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@igorcrevar igorcrevar added the bug fix Functionality that fixes a bug label Mar 30, 2023
@igorcrevar igorcrevar self-assigned this Mar 30, 2023
@igorcrevar igorcrevar force-pushed the EVM-568_IncreaseMaxBlockBacklogforblocktracker branch from 148d314 to 9a592be Compare March 30, 2023 16:15
@igorcrevar igorcrevar merged commit 7b7ee40 into develop Mar 31, 2023
@igorcrevar igorcrevar deleted the EVM-568_IncreaseMaxBlockBacklogforblocktracker branch March 31, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Functionality that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants