EVM-568 Increase MaxBlockBacklog for block tracker #1347
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of the event tracker is the block tracker, which fetches blocks from provided JSON RPC endpoint. In order to determine if there are reorgs happening, there is a MaxBlockBacklog parameter. It turned out that default value of 10 blocks is not big enough.
The solution proposal is to initialize the
MaxBlockBacklog
parameter as2*NumBlockConfirmations
(or consider putting even more).BlockTracker
creation/initialization is moved totracker/event_tracker.go
. That way we have much more options when configuring blocktrackerChanges include
Checklist
Testing