-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EVM-535: Use contractsapi bindings throught code #1321
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goran-ethernal
force-pushed
the
Use-contractsapi-throught-code
branch
from
March 21, 2023 15:50
90ed8f7
to
56edf81
Compare
goran-ethernal
requested review from
Stefan-Ethernal,
Nemanja0x,
vcastellm and
igorcrevar
March 21, 2023 18:26
goran-ethernal
changed the title
Use contractsapi bindings throught code
EVM-535: Use contractsapi bindings throught code
Mar 22, 2023
goran-ethernal
force-pushed
the
Use-contractsapi-throught-code
branch
from
March 22, 2023 12:05
56edf81
to
46563b1
Compare
Stefan-Ethernal
approved these changes
Mar 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
Leaving some thoughts to consider.
goran-ethernal
force-pushed
the
Use-contractsapi-throught-code
branch
3 times, most recently
from
March 23, 2023 12:36
24b7b79
to
dd38fb2
Compare
vcastellm
reviewed
Mar 24, 2023
goran-ethernal
force-pushed
the
Use-contractsapi-throught-code
branch
from
March 24, 2023 12:17
f5d6436
to
f4c929d
Compare
vcastellm
approved these changes
Mar 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR uses the
contractsapi
package and generatedgo
stubs from contract functions and events, on places where it was missing.PR expanded the
ParseLog
function on generatedgo
stubs for contract events, so that the function returns two values:boolean
- indicating if the given log matches the given event.error
- if a log matches the event, but its parsing fails for some reason.This simplifies the code on client that first matched the events with log, and then parsed it, shortening the code, and removing the manually added references to an event abi.
Changes include
Checklist
Testing