Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate NativeERC20Mintable token contract #1316

Merged
merged 6 commits into from
Mar 23, 2023
Merged

Integrate NativeERC20Mintable token contract #1316

merged 6 commits into from
Mar 23, 2023

Conversation

Stefan-Ethernal
Copy link
Collaborator

Description

This PR deploys and integrates NativeERC20Mintable token. It allows token to be minted by either child chain predicate or the predefined owner account (as of now it is set to be first genesis validator).

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@Stefan-Ethernal Stefan-Ethernal added the feature New update to Polygon Edge label Mar 20, 2023
@Stefan-Ethernal Stefan-Ethernal self-assigned this Mar 20, 2023
@Stefan-Ethernal Stefan-Ethernal changed the title Integrate native erc 20 mintable contract Integrate NativeERC20Mintable token contract Mar 20, 2023
@Stefan-Ethernal Stefan-Ethernal marked this pull request as draft March 21, 2023 06:54
@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-511-integrate-native-erc-20-mintable-contract branch from 8b6f2a4 to 4f2b6f7 Compare March 21, 2023 10:21
@Stefan-Ethernal Stefan-Ethernal marked this pull request as ready for review March 21, 2023 10:21
@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-511-integrate-native-erc-20-mintable-contract branch from 4f2b6f7 to 0f127c2 Compare March 21, 2023 10:59
@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-511-integrate-native-erc-20-mintable-contract branch from 3e3847b to f80718a Compare March 22, 2023 13:15
@Stefan-Ethernal Stefan-Ethernal merged commit 90d8020 into develop Mar 23, 2023
@Stefan-Ethernal Stefan-Ethernal deleted the EVM-511-integrate-native-erc-20-mintable-contract branch March 23, 2023 08:49
@github-actions github-actions bot locked and limited conversation to collaborators Mar 23, 2023
vcastellm
vcastellm reviewed Mar 24, 2023
View reviewed changes
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Late LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vcastellm vcastellm vcastellm left review comments

@goran-ethernal goran-ethernal goran-ethernal approved these changes

@ferranbt ferranbt ferranbt approved these changes

@igorcrevar igorcrevar igorcrevar approved these changes

@b00ris b00ris Awaiting requested review from b00ris

@Nemanja0x Nemanja0x Awaiting requested review from Nemanja0x

Assignees

@Stefan-Ethernal Stefan-Ethernal

Labels
feature New update to Polygon Edge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Stefan-Ethernal @vcastellm @igorcrevar @ferranbt @goran-ethernal