Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower log level of the ProposerCalculator logs #1300

Merged
merged 2 commits into from
Mar 22, 2023

Conversation

Stefan-Ethernal
Copy link
Collaborator

Description

This PR lowers the log level of ProposerCalculator logs from info to debug level. It also rewords some of them.

The rationale for doing it is that info is the default logging level and these logs are reported per block, so probably no need to output them on the info level for each block.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@Stefan-Ethernal Stefan-Ethernal added the bug fix Functionality that fixes a bug label Mar 16, 2023
@Stefan-Ethernal Stefan-Ethernal self-assigned this Mar 16, 2023
@Stefan-Ethernal Stefan-Ethernal changed the title Lower log level of ProposerCalculator logs Lower log level of the ProposerCalculator logs Mar 16, 2023
@Stefan-Ethernal Stefan-Ethernal merged commit 05d6186 into develop Mar 22, 2023
@Stefan-Ethernal Stefan-Ethernal deleted the EVM-526-revise-proposer-calculator-log-level branch March 22, 2023 11:36
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Functionality that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants