forked from 0xPolygonHermez/zkevm-node
-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/beethoven #44
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
begmaroman
approved these changes
Dec 19, 2023
# TODO: REMOVE SSH BEFORE MERGING, ONCE BEETHOVEN IS PUBLIC | ||
|
||
# SSH KEY | ||
ARG SSH_PRIVATE_KEY |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is another option to do it via git token
Dockerfile:
ENV GOPRIVATE="github.com/0xPolygon/beethoven"
ADD scripts/git-configure.sh .gittoken ./
RUN mkdir -p -m 0600 ~/.ssh && \
ssh-keyscan github.com >> ~/.ssh/known_hosts && \
sh ./git-configure.sh
scripts/git-configure.sh
#!/bin/sh
# This script is needed to support using packages from private repos.
# This script applies the given github token if exists, otherwise tells to use ssh instead of https for downloading repos.
export GITHUB_TOKEN=$(cat .gittoken)
if [[ -z "${GITHUB_TOKEN}" ]]; then
git config --global url.ssh://[email protected]/.insteadOf https://github.com/
else
git config --global url."https://$GITHUB_TOKEN:[email protected]/".insteadOf "https://github.com/"
fi
.gittoken (ignorred)
<git-token>
Also just FYI
vcastellm
reviewed
Dec 20, 2023
aggregator/config.go
Outdated
// BeethovenURL url of the beethoven service | ||
BeethovenURL string `mapstructure:"BeethovenURL"` | ||
|
||
// PrivateKey of the sequencer, used to authorize txs sent to the beethoven |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linter prefers
Suggested change
// PrivateKey of the sequencer, used to authorize txs sent to the beethoven | |
// SequencerPrivateKey of the sequencer, used to authorize txs sent to the beethoven |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate Beethoven
Beethoven should be open source before merging