Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/beethoven #44

Closed
wants to merge 7 commits into from
Closed

Feature/beethoven #44

wants to merge 7 commits into from

Conversation

arnaubennassar
Copy link
Collaborator

@arnaubennassar arnaubennassar commented Dec 19, 2023

Integrate Beethoven

Beethoven should be open source before merging

# TODO: REMOVE SSH BEFORE MERGING, ONCE BEETHOVEN IS PUBLIC

# SSH KEY
ARG SSH_PRIVATE_KEY

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is another option to do it via git token

Dockerfile:

ENV GOPRIVATE="github.com/0xPolygon/beethoven"
ADD scripts/git-configure.sh .gittoken ./
RUN mkdir -p -m 0600 ~/.ssh && \
  ssh-keyscan github.com >> ~/.ssh/known_hosts && \
  sh ./git-configure.sh

scripts/git-configure.sh

#!/bin/sh

# This script is needed to support using packages from private repos.
# This script applies the given github token if exists, otherwise tells to use ssh instead of https for downloading repos.

export GITHUB_TOKEN=$(cat .gittoken)

if [[ -z "${GITHUB_TOKEN}" ]]; then
    git config --global url.ssh://[email protected]/.insteadOf https://github.com/
else
    git config --global url."https://$GITHUB_TOKEN:[email protected]/".insteadOf "https://github.com/"
fi

.gittoken (ignorred)

<git-token>

Also just FYI

// BeethovenURL url of the beethoven service
BeethovenURL string `mapstructure:"BeethovenURL"`

// PrivateKey of the sequencer, used to authorize txs sent to the beethoven

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linter prefers

Suggested change
// PrivateKey of the sequencer, used to authorize txs sent to the beethoven
// SequencerPrivateKey of the sequencer, used to authorize txs sent to the beethoven

@vcastellm vcastellm closed this Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants