add bridge convenience script #93
Conversation
| account = args.account or config["contract_deployer_account"] | ||
|
|
||
| bridge_proxy = json.load( | ||
| open(os.path.join('deployments', args.name, 'artifacts', 'addresses.json')))['L1StandardBridgeProxy'] |
There was a problem hiding this comment.
You can use config.addresses_path for this.
There was a problem hiding this comment.
Seems like there is a difference between config_file from config.toml and config from the "Config" object in the generated in deployments/** that I overlooked. I propose (if I may) to leave it like this in this PR.
I'm pretty sure this will resolve itself when I start moving the bridge script into a subcommand since I'll have access to config_file and the Config object directly.
bridge.py
Outdated
| open(os.path.join('deployments', args.name, 'artifacts', 'addresses.json')))['L1StandardBridgeProxy'] | ||
|
|
||
| if not private_key or not account: | ||
| sys.exit("Private key, account, and amount must be provided either via arguments or config.") |
There was a problem hiding this comment.
The amount has a default value so it does not need to be provided.
bridge.py
Outdated
| unit = match.group(4) or 'ether' | ||
| return f"{amount}{unit}" | ||
| else: | ||
| raise ValueError("Invalid amount format.") |
There was a problem hiding this comment.
Useful function! Could you move it to libroll/libroll.py?
| ] | ||
|
|
||
| lib.run("sending eth to L1StandardBridgeProxy contract.", cast_command) | ||
| print("Successfully sent transaction to L1StandardBridgeProxy.") |
There was a problem hiding this comment.
It would be cool to optionally enable waiting until the bridge has been processed on the other side. Probably a sleep loop that polls, but I'm not exactly sure what to poll on the L2 side. I wonder if there isn't a call that can be made on one of the contracts (the message passer?) with the tx hash or something?
Let's keep that for another PR if you're interested!
|
Hey there! Sorry for the delay in the review, and thanks for the contribution 🙏
Both can be good, but I'm wondering if it's maybe not better as a subcommand as it allows reusing the config loading logic (which does a few things beyond just loading the TOML, though not sure they are relevant in this use case from the top of my head). The only downside is polluting the command space a bit, but maybe we can make it a "script" command and make this a "bridge" subcommand (and then if we add other scripts like this we can add them there as well).
The default in the loading logic I mention above is the The default is What I propose: let's merge this (maybe if you can move the utility function to the library first?). Then if you're motivated, an extra PR to integrate this as a subcommand, and/or to optionally wait for the bridge to complete would be more than welcome! Thanks again! |
Made a basic bridge script for #78
Had two questions: