Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update Golang 1.19 #613

Merged
merged 4 commits into from
Sep 19, 2022
Merged

Conversation

soulteary
Copy link
Contributor

No description provided.

@soulteary soulteary mentioned this pull request Aug 3, 2022
Copy link
Owner

@0xERR0R 0xERR0R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Base: 91.61% // Head: 91.61% // No change to project coverage 👍

Coverage data is based on head (f7a0c26) compared to base (bd2cb58).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##           development     #613   +/-   ##
============================================
  Coverage        91.61%   91.61%           
============================================
  Files               39       39           
  Lines             4471     4471           
============================================
  Hits              4096     4096           
  Misses             307      307           
  Partials            68       68           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@0xERR0R
Copy link
Owner

0xERR0R commented Aug 3, 2022

Go 1.19 was just released, golangci-lint job fails currently. Maybe they need some time to support 1.19. I found this issue: golangci/golangci-lint#2922

@0xERR0R 0xERR0R added the ⚙️ dependencies Pull requests that update a dependency file label Aug 3, 2022
@rhcarvalho
Copy link

Hi! Have a look at golangci/golangci-lint-action#442 (comment), maybe building golangci-lint from source is an option for you.

@0xERR0R
Copy link
Owner

0xERR0R commented Aug 3, 2022

Hi! Have a look at golangci/golangci-lint-action#442 (comment), maybe building golangci-lint from source is an option for you.

Thanks for the hint, I'll try it out

@0xERR0R 0xERR0R added the 🛑 blocked Waiting for external dependency label Aug 3, 2022
@kwitsch kwitsch linked an issue Aug 23, 2022 that may be closed by this pull request
@github-actions
Copy link
Contributor

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@soulteary
Copy link
Contributor Author

Time flies so fast, I don't know what else is needed for this PR? @0xERR0R

@0xERR0R
Copy link
Owner

0xERR0R commented Sep 18, 2022

Your PR is just fine. I'm waiting for golang 1.19 support in golangci-lint

@0xERR0R 0xERR0R added this to the 0.20 milestone Sep 19, 2022
@0xERR0R 0xERR0R removed the 🛑 blocked Waiting for external dependency label Sep 19, 2022
@0xERR0R 0xERR0R merged commit c454c32 into 0xERR0R:development Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Golang 1.19
3 participants