-
-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update Golang 1.19 #613
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
Codecov ReportBase: 91.61% // Head: 91.61% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## development #613 +/- ##
============================================
Coverage 91.61% 91.61%
============================================
Files 39 39
Lines 4471 4471
============================================
Hits 4096 4096
Misses 307 307
Partials 68 68 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Go 1.19 was just released, golangci-lint job fails currently. Maybe they need some time to support 1.19. I found this issue: golangci/golangci-lint#2922 |
Hi! Have a look at golangci/golangci-lint-action#442 (comment), maybe building golangci-lint from source is an option for you. |
Thanks for the hint, I'll try it out |
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Time flies so fast, I don't know what else is needed for this PR? @0xERR0R |
Your PR is just fine. I'm waiting for golang 1.19 support in golangci-lint |
No description provided.