Skip to content

Commit

Permalink
Add note about SARIF and fail-on behavior on earlier Slither releases
Browse files Browse the repository at this point in the history
  • Loading branch information
elopez committed Sep 9, 2022
1 parent 2b01696 commit b710c70
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,16 @@ config` to prevent the action from overriding your settings.
| `low` | Fail on any finding | Fail on any finding >= low
| `medium` | Fail on any finding | Fail on any finding >= medium
| `high` | Fail on any finding | Fail on any finding >= high
| `none` | Do not fail on findings | Do not fail on findings
| `none` | Do not fail on findings | Do not fail on findings
| `config` | Determined by config file | Determined by config file

† Note that if you use `fail-on: none` with Slither 0.8.3 or earlier, certain
functionality may not work as expected. In particular, Slither will not produce
a SARIF file in this case. If you require `fail-on: none` behavior with the
SARIF integration, consider adding [`continue-on-error:
true`](https://docs.github.com/es/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepscontinue-on-error)
instead to the action step.

### Using a different Slither version

If the latest Slither release has a bug that does not let you analyze your
Expand Down

0 comments on commit b710c70

Please sign in to comment.