Skip to content

Commit

Permalink
Protect against accidental SOLC_VERSION clash from workflow
Browse files Browse the repository at this point in the history
Users may set SOLC_VERSION in the workflow and cause hard-to-diagnose
problems in the action (see crytic#19). To avoid that
from happening, unset SOLC_VERSION early on. If the user desires
to change the solc version, they can always use the `solc-version`
action option.
  • Loading branch information
elopez committed Jul 29, 2022
1 parent df7985c commit 7a59832
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions entrypoint.sh
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,11 @@ SLITHERARGS="$(get INPUT_SLITHER-ARGS)"
SLITHERCONF="$(get INPUT_SLITHER-CONFIG)"
IGNORECOMPILE="$(get INPUT_IGNORE-COMPILE)"

# #19 - an user may set SOLC_VERSION in the workflow and cause problems here.
# Make sure it's unset. If you need to use a different solc version, override
# it with the `solc-version` action option.
unset SOLC_VERSION

compatibility_link()
{
HOST_GITHUB_WORKSPACE="$(get INPUT_INTERNAL-GITHUB-WORKSPACE | tr -d \")"
Expand Down

0 comments on commit 7a59832

Please sign in to comment.