Log errors to console if no handler is available

0x80 · Dec 15, 2022 · e792ca2 · e792ca2
1 parent 0780b61
commit e792ca2
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 15 deletions.
diff --git a/src/collection.ts b/src/collection.ts
@@ -318,21 +318,6 @@ export class ObservableCollection<T extends DocumentData> {
       `handleSnapshot, ${Date.now()} docs.length: ${snapshot.docs.length}`,
     );
 
-    /**
-     * @TODO keep local cache of each document and only update data based on the
-     * docChanges
-     */
-    // snapshot.docChanges().forEach(function(change) { if (change.type ===
-    //   "added") { console.log("New: ", change.doc.data());
-    //   }
-    //   if (change.type === "modified") { console.log("Modified: ",
-    //     change.doc.data());
-    //   }
-    //   if (change.type === "removed") { console.log("Removed: ",
-    //     change.doc.data());
-    //   }
-    // });
-
     runInAction(() => {
       this._documents = snapshot.docs.map(
         (doc) =>

diff --git a/src/document.ts b/src/document.ts
@@ -282,6 +282,7 @@ export class ObservableDocument<T extends DocumentData> {
     if (typeof this.onErrorCallback === "function") {
       this.onErrorCallback(err);
     } else {
+      this.logError(err);
       throw err;
     }
   }
@@ -350,6 +351,20 @@ export class ObservableDocument<T extends DocumentData> {
     }
   }
 
+  private logError(err: unknown) {
+    if (!this.documentRef) {
+      console.error(
+        `${this.debugId} (${getPathFromCollectionRef(
+          this.collectionRef,
+        )}): ${getErrorMessage(err)}`,
+      );
+    } else {
+      console.error(
+        `${this.debugId} (${this.documentRef.path}): ${getErrorMessage(err)}`,
+      );
+    }
+  }
+
   private updateListeners(shouldListen: boolean) {
     const isListening = !!this.onSnapshotUnsubscribeFn;