Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lang: Update french translation #1197

Merged
merged 5 commits into from
Feb 16, 2023

Conversation

ArmandDelessert
Copy link
Contributor

PR Type

Update french translation.

However, the French translation takes up more space than the English one and overflows the side panel:

French translation updated in advanced settings panel

Should a line break be added? Like below? (Same problem for the "Enable session snapshot" setting.)

French translation with new line in advanced settings panel

@ArmandDelessert ArmandDelessert marked this pull request as ready for review February 15, 2023 10:35
@0x7c13 0x7c13 self-assigned this Feb 15, 2023
@0x7c13
Copy link
Owner

0x7c13 commented Feb 15, 2023

Yes, please add a line breaker to both places. Thanks!

@0x7c13 0x7c13 self-requested a review February 15, 2023 19:42
@ArmandDelessert
Copy link
Contributor Author

Yes, please add a line breaker to both places. Thanks!

Done.

@0x7c13 0x7c13 merged commit 3a84eb2 into 0x7c13:master Feb 16, 2023
@ArmandDelessert ArmandDelessert deleted the UpdateFrenchTranslations branch June 11, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants