Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated JavaFX to version 19, Java to version 17. #22

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Oliver-Loeffler
Copy link

Could fix issue #21
Beside JavaFX/Java versions, I've bumped the version number to 3.2.0.

@Oliver-Loeffler
Copy link
Author

Well, JavaFX 19 runs well with Java 11. Hence I've reverted the Java target version to 11.
Technically a JavaFX 19 based build is still something to be considered as with JLink and JPackage the exclusion of JavaFX 11 dependencies did not yield in a working executable. Need to continue to play around with this.

Also was thinking about versioning. Not sure of incrementing the minor version for that is the right approach. I've observed that for e.g. JDBC drivers the library version often gets a jdkXY or jreXY suffix. Same could help here, e.g. 3.1.0.javafx19 or 3.1.0.fx19. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant