Merge pull request #24 from 0x4447/development

Version bump
0x4447 · Aug 26, 2019 · a964367 · a964367
2 parents b29e17c + 0d1568f
commit a964367
Show file tree

Hide file tree

Showing 7 changed files with 296 additions and 344 deletions.
diff --git a/03_Parameters/github_account_name.json b/03_Parameters/github_account_name.json
@@ -0,0 +1,7 @@
+{
+	"ParamGitHubAccountName": {
+		"Description": "The name of the GitHub account, it is the same names that you find in the URL. Organization or private account.",
+		"Type": "String",
+		"Default": "0x4447"
+	}
+}
diff --git a/03_Parameters/github_token.json b/03_Parameters/github_token.json
@@ -1,6 +1,6 @@
 {
 	"GitHubToken": {
-		"Description": "You need to create a Personal access tokens (https://github.com/settings/tokens) for CodePipeline to have access to the GitHub repo despite it being public.",
+		"Description": "You need to create a Personal access tokens (https://github.com/settings/tokens) for CodePipeline to have access to the GitHub repo even if they are public, and the Scope has to have: repo and admin:repo_hook",
 		"NoEcho": true,
 		"Type": "String"
 	}

diff --git a/07_Resources/Repos/converter/CodePipeline/_index.json b/07_Resources/Repos/converter/CodePipeline/_index.json
@@ -22,7 +22,7 @@
 								"Version": "1"
 							},
 							"Configuration": {
-								"Owner": "0x4447",
+								"Owner": { "Ref": "ParamGitHubAccountName" },
 								"Repo": "0x4447-product-s3-email-lambda-converter",
 								"Branch": { "Ref": "Stage" },
 								"PollForSourceChanges": false,

diff --git a/07_Resources/Repos/inbound/CodePipeline/_index.json b/07_Resources/Repos/inbound/CodePipeline/_index.json
@@ -22,7 +22,7 @@
 								"Version": "1"
 							},
 							"Configuration": {
-								"Owner": "0x4447",
+								"Owner": { "Ref": "ParamGitHubAccountName" },
 								"Repo": "0x4447-product-s3-email-lambda-inbound",
 								"Branch": { "Ref": "Stage" },
 								"PollForSourceChanges": false,

diff --git a/07_Resources/Repos/outbound/CodePipeline/_index.json b/07_Resources/Repos/outbound/CodePipeline/_index.json
@@ -22,7 +22,7 @@
 								"Version": "1"
 							},
 							"Configuration": {
-								"Owner": "0x4447",
+								"Owner": { "Ref": "ParamGitHubAccountName" },
 								"Repo": "0x4447-product-s3-email-lambda-outbound",
 								"Branch": { "Ref": "Stage" },
 								"PollForSourceChanges": false,