Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for viewport issue #22

Merged
merged 2 commits into from
Jun 18, 2020
Merged

Fix for viewport issue #22

merged 2 commits into from
Jun 18, 2020

Conversation

0x111
Copy link
Owner

@0x111 0x111 commented Jun 11, 2020 •
edited
Loading

  • Set a wider viewport, this way force the browser to render a non-mobile version of the website
  • Correct timeout functionality, since the current implementation did not work correctly

Fixes #19

To test this, pull the pr-latest branch from docker hub.

docker pull ruthless/servicenow-instance-wakeup:pr-latest

@0x111
- Set a wider viewport, this way force the browser to render a non-mo…
853773e 
…bile version of the app

- Correct timeout functionality, since the current implementation did not work correctly
@0x111 0x111 added the fix Fixes a bug label Jun 11, 2020
@0x111 0x111 self-assigned this Jun 11, 2020
@0x111 0x111 merged commit 194ee79 into master Jun 18, 2020
@0x111 0x111 deleted the fix-element-not-found branch June 18, 2020 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@0x111 0x111

Labels
fix Fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Timeout error?
1 participant
@0x111