Redesign the task flow post Orlando release #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me output on what the app is actually doing - Add an option to specify timeout in the cli and config file
Add disclaimer and clarify what this app does in the detail to prevent confusions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Servicenow apparently changed their DEV portal, due to the fact, the old logic does not work anymore and we needed to make some changes.
I also wanted to use this opportunity to rewrite the flow of how the tasks/actions are run. This will provide for a more streamlined user experience running this app.
This way you will know what is happening or what step had failed.
You will be able to configure the timeout too, on some networks and hardware you need less, somewhere more. It is completely configurable and has a default of 60 seconds which should be enough in most cases.
Right now I need you. Please test if this is working accordingly to wakeup your instances. Unfortunately I did introduce a dirty hack too
time.Sleep(5*time.Second), without this chromedp could not click the button.I am open to suggestions, but I am not able to test this as often as I would like to, due to the instance going to sleep once in a while. So please let me know if it works for you.
Here are the pre-built binaries for testing:
v0.5-pre