Make the mempool's default_failovers=3 for VFN stability. #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diem tries to optimize VFNs by setting mempool's default_failovers to 0. I believe this is because it expects a VFN's validator to be up and if it is down, the default_failovers param doesn't apply anyways. Since well behaving validators can be dropped from the set due to PoF competition, we want to override this optimization and maintain failovers. 0L network had this param set to 3 before v6.9 and it should be maintained.
|
@misko9 please pull in latest changes from main |
0o-de-lally
pushed a commit
that referenced
this pull request
Aug 8, 2024
0o-de-lally
pushed a commit
that referenced
this pull request
Aug 8, 2024
0o-de-lally
pushed a commit
to 0o-de-lally/libra-framework
that referenced
this pull request
Aug 16, 2024
0o-de-lally
pushed a commit
to 0o-de-lally/libra-framework
that referenced
this pull request
Aug 16, 2024
0o-de-lally
pushed a commit
to 0o-de-lally/libra-framework
that referenced
this pull request
Aug 16, 2024
0o-de-lally
pushed a commit
to 0o-de-lally/libra-framework
that referenced
this pull request
Aug 16, 2024
0o-de-lally
pushed a commit
to 0o-de-lally/libra-framework
that referenced
this pull request
Aug 16, 2024
0o-de-lally
pushed a commit
to 0o-de-lally/libra-framework
that referenced
this pull request
Aug 17, 2024
0o-de-lally
pushed a commit
to 0o-de-lally/libra-framework
that referenced
this pull request
Aug 17, 2024
0o-de-lally
pushed a commit
to 0o-de-lally/libra-framework
that referenced
this pull request
Aug 17, 2024
0o-de-lally
pushed a commit
to 0o-de-lally/libra-framework
that referenced
this pull request
Aug 17, 2024
0o-de-lally
pushed a commit
to 0o-de-lally/libra-framework
that referenced
this pull request
Aug 17, 2024
0o-de-lally
pushed a commit
to 0o-de-lally/libra-framework
that referenced
this pull request
Aug 17, 2024
0o-de-lally
pushed a commit
to 0o-de-lally/libra-framework
that referenced
this pull request
Aug 17, 2024
0o-de-lally
pushed a commit
that referenced
this pull request
Aug 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diem tries to optimize VFNs by setting mempool's default_failovers to 0. I believe this is because it expects a VFN's validator to be up and if it is down, the default_failovers param doesn't apply anyways. Since well behaving validators can be dropped from the set due to PoF competition, we want to override this optimization and maintain failovers. 0L network had this param set to 3 before v6.9 and it should be maintained.