-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct tail recursion & improve compiler complexity #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
wader
reviewed
Nov 5, 2024
wader
added a commit
to wader/jqjq
that referenced
this pull request
Nov 5, 2024
Useful snippets and refrenses: jaq -L . -n 'include "jqjq"; _builtins_src | lex' jaq -n -L . -rRs 'include "jqjq"; . | jqjq(["", "--run-tests"]; {})' < jqjq.test jaq -n -L . 'include "jqjq"; eval("1+2")' Disable TCO 01mf02/jaq#223 (comment)
wader
added a commit
to wader/jqjq
that referenced
this pull request
Nov 5, 2024
Useful snippets and referencses: jaq -L . -n 'include "jqjq"; _builtins_src | lex' jaq -n -L . -rRs 'include "jqjq"; . | jqjq(["", "--run-tests"]; {})' < jqjq.test jaq -n -L . 'include "jqjq"; eval("1+2")' Disable TCO 01mf02/jaq#223 (comment)
wader
added a commit
to wader/jqjq
that referenced
this pull request
Nov 5, 2024
Useful snippets and references: jaq -L . -n 'include "jqjq"; _builtins_src | lex' jaq -n -L . -rRs 'include "jqjq"; . | jqjq(["", "--run-tests"]; {})' < jqjq.test jaq -n -L . 'include "jqjq"; eval("1+2")' Disable TCO 01mf02/jaq#223 (comment)
wader
added a commit
to wader/jqjq
that referenced
this pull request
Nov 5, 2024
Useful snippets and references: jaq -L . -n 'include "jqjq"; _builtins_src | lex' jaq -n -L . -rRs 'include "jqjq"; . | jqjq(["", "--run-tests"]; {})' < jqjq.test jaq -n -L . 'include "jqjq"; eval("1+2")' Disable TCO 01mf02/jaq#223 (comment)
wader
added a commit
to wader/jqjq
that referenced
this pull request
Nov 5, 2024
Useful snippets and references: jaq -L . -n 'include "jqjq"; _builtins_src | lex' jaq -n -L . -rRs 'include "jqjq"; . | jqjq(["", "--run-tests"]; {})' < jqjq.test jaq -n -L . 'include "jqjq"; eval("1+2")' Disable TCO 01mf02/jaq#223 (comment)
wader
added a commit
to wader/jqjq
that referenced
this pull request
Nov 13, 2024
Useful snippets and references: jaq -L . -n 'include "jqjq"; _builtins_src | lex' jaq -n -L . -rRs 'include "jqjq"; . | jqjq(["", "--run-tests"]; {})' < jqjq.test jaq -n -L . 'include "jqjq"; eval("1+2")' Disable TCO 01mf02/jaq#223 (comment)
wader
added a commit
to wader/jqjq
that referenced
this pull request
Nov 15, 2024
Useful snippets and references: jaq -L . -n 'include "jqjq"; _builtins_src | lex' jaq -n -L . -rRs 'include "jqjq"; . | jqjq(["", "--run-tests"]; {})' < jqjq.test jaq -n -L . 'include "jqjq"; eval("1+2")' Disable TCO 01mf02/jaq#223 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #216, @wader found an expression
t
that would not yield the same result ast | .
.This boiled down to a bug in tail-call optimisation (TCO).
This PR corrects this bug. At the same time, it makes compilation more efficient, in particular when there are many definitions, variables, or labels. For example:
Previously, this would have taken quadratic time (with increasing values of
seq ...
); now, this takes n * log n time.On the downside, the startup time becomes slightly longer for very small programs.
Here, we can see slightly worse values for
empty
, but improvements forack
.