Time Series Insights - Fixes on existing api-versions (Azure#8758)

* Fix or suppress spec violations Fix R2016 by making PATCH body properties optional. Suppress the remaining 4 violations that are confirmed as false positives. * Try removing 2nd top-level heading, which _may_ have been causing a linter warning. * Fix extra indention which prevented linter from running. * Added dataStringComparisonBehavior parameter to reference data put/update spec. * Fixed grammar. * adding partitionkeyProperty to environmentInfo * changing property name * changing modelAsString * Initial checkin of spec. Unchanged from GA release other than version. * Remove .orig files * Fix validation error by removing IoTHub ES from List ES example response * Add extra example that was missing from preview spec. * Add long-term environment to resource hierarchy, and update examples. * Switch to model-as-string for enums. Restore EnvironmentResource's inheritance from TrackedResource. * Upsate sku description * Add new TSI preview api-version to readme.md. * Add suppressions for false-positive linter failures. * Test suppression failures * Adding preview package tag to several other places in readme.md * Add preview package to the readme.go.md file * Remove invalid required property from EnvironmentCreateOrUpdateParameters * Initial version of data plane swagger spec for PAYG (Preview) SKU. * Added missing Readme.md * Fixed name of readme * Fixed path to swagger json * Attempt to fix readme * Apply suggestions from code review Co-Authored-By: dmdenmsft <[email protected]> * Update timeseriesinsights.json * Update timeseriesinsights.json * Added link to oav issue * Changing creation time to RFC1123 when TSI Environments are part of the response body * Renaming $expand to expand * Fixing patch Environment supporting S* and L1 parameters * Reverting creationTime format change * Tweaking Environments_Update to support inheritance * Fixing grammar * Fixing Microsoft.IoTHub namespace * Reverting environmentUpdateParameters renaming * Renaming expand back to $expand * Applying updates based on feedbacks * Removing partitionKeyProperties from StandardEnvironmentMutableProperties * Changing partitionKeyProperty description * Removing the flattening from warmStoreConfiguration * Removing maxlength from array * Removing support for other LocalTimeStamp formats than Embedded Co-authored-by: Eric Dettinger <[email protected]> Co-authored-by: Karthik Subramanian <[email protected]> Co-authored-by: Ravi Kumar Suresh Babu <[email protected]> Co-authored-by: ravikumarsureshbabu <[email protected]> Co-authored-by: Dmitry Denisov <[email protected]> Co-authored-by: Nick Schonning <[email protected]> Co-authored-by: Karthik Subramanian <[email protected]>
00Kai0 · Oct 12, 2020 · 63e77d2 · 63e77d2
1 parent 3378800
commit 63e77d2
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 24 deletions.
diff --git a/...xamples/EnvironmentsPatchSkuCapacity.json → ...eview/examples/EnvironmentsPatchTags.json b/...xamples/EnvironmentsPatchSkuCapacity.json → ...eview/examples/EnvironmentsPatchTags.json
@@ -3,10 +3,9 @@
     "subscriptionId": "subid",
     "resourceGroupName": "rg1",
     "environmentName": "env1",
-    "standardEnvironmentUpdateParameters": {
-      "sku": {
-        "name": "S1",
-        "capacity": 10
+    "environmentUpdateParameters": {
+      "tags": {
+        "someTag": "someTagValue"
       }
     },
     "api-version": "2018-08-15-preview"
@@ -19,7 +18,9 @@
         "name": "env1",
         "type": "Microsoft.TimeSeriesInsights/Environments",
         "kind": "Standard",
-        "tags": {},
+        "tags": {
+          "someTag": "someTagValue"
+        },
         "properties": {
           "dataRetentionTime": "P31D",
           "provisioningState": "Succeeded",

diff --git a/...e-manager/Microsoft.TimeSeriesInsights/preview/2018-08-15-preview/timeseriesinsights.json b/...e-manager/Microsoft.TimeSeriesInsights/preview/2018-08-15-preview/timeseriesinsights.json
@@ -181,7 +181,7 @@
         "operationId": "Environments_Update",
         "x-ms-examples": {
           "EnvironmentsUpdate": {
-            "$ref": "./examples/EnvironmentsPatchSkuCapacity.json"
+            "$ref": "./examples/EnvironmentsPatchTags.json"
           }
         },
         "x-ms-long-running-operation": true,
@@ -197,11 +197,11 @@
             "$ref": "#/parameters/EnvironmentNameParameter"
           },
           {
-            "name": "standardEnvironmentUpdateParameters",
+            "name": "environmentUpdateParameters",
             "in": "body",
             "required": true,
             "schema": {
-              "$ref": "#/definitions/StandardEnvironmentUpdateParameters"
+              "$ref": "#/definitions/EnvironmentUpdateParameters"
             },
             "description": "Request object that contains the updated information for the environment."
           },
@@ -211,7 +211,7 @@
         ],
         "responses": {
           "200": {
-            "description": "The environment definition was successfully updated and is in the response. If the environment was updated synchronously, the response will include a provisioningState value of \"Succeeded\". If the environment was updated asynchronous, the response will include a provisioningState value of \"Updating\".  You can periodically get your environment definition and monitor progress of the update via the provisioningState property.",
+            "description": "The environment definition was successfully updated and is in the response. If the environment was updated synchronously, the response will include a provisioningState value of \"Succeeded\". If the environment was updated asynchronously, the response will include a provisioningState value of \"Updating\".  You can periodically get your environment definition and monitor progress of the update via the provisioningState property.",
             "schema": {
               "$ref": "#/definitions/EnvironmentResource"
             }
@@ -1547,7 +1547,7 @@
           "items": {
             "$ref": "#/definitions/TimeSeriesIdProperty"
           },
-          "description": "The list of event properties which will be used to partition data in the environment."
+          "description": "The list of event properties which will be used to partition data in the environment. Currently, only a single partition key property is supported."
         }
       },
       "required": [
@@ -1569,7 +1569,7 @@
           "description": "The storage configuration provides the connection details that allows the Time Series Insights service to connect to the customer storage account that is used to store the environment's data."
         },
         "warmStoreConfiguration": {
-          "x-ms-client-flatten": true,
+          "x-ms-client-flatten": false,
           "$ref": "#/definitions/WarmStoreConfigurationProperties",
           "description": "The warm store configuration provides the details to create a warm store cache that will retain a copy of the environment's data available for faster query."
         }
@@ -1636,7 +1636,7 @@
           "description": "The storage configuration provides the connection details that allows the Time Series Insights service to connect to the customer storage account that is used to store the environment's data."
         },
         "warmStoreConfiguration": {
-          "x-ms-client-flatten": true,
+          "x-ms-client-flatten": false,
           "$ref": "#/definitions/WarmStoreConfigurationProperties",
           "description": "The warm store configuration provides the details to create a warm store cache that will retain a copy of the environment's data available for faster query."
         }
@@ -1675,13 +1675,6 @@
             "name": "StorageLimitExceededBehavior",
             "modelAsString": true
           }
-        },
-        "partitionKeyProperties": {
-          "type": "array",
-          "items": {
-            "$ref": "#/definitions/TimeSeriesIdProperty"
-          },
-          "description": "The list of event properties which will be used to partition data in the environment."
         }
       }
     },
@@ -1694,7 +1687,7 @@
           "description": "The storage configuration provides the connection details that allows the Time Series Insights service to connect to the customer storage account that is used to store the environment's data."
         },
         "warmStoreConfiguration": {
-          "x-ms-client-flatten": true,
+          "x-ms-client-flatten": false,
           "$ref": "#/definitions/WarmStoreConfigurationProperties",
           "description": "The warm store configuration provides the details to create a warm store cache that will retain a copy of the environment's data available for faster query."
         }
@@ -1848,6 +1841,10 @@
             "name": "Kind",
             "modelAsString": true
           }
+        },
+        "localTimestamp": {
+          "$ref": "#/definitions/LocalTimestamp",
+          "description": "An object that represents the local timestamp property. It contains the format of local timestamp that needs to be used and the corresponding timezone offset information. If a value isn't specified for localTimestamp, or if null, then the local timestamp will not be ingressed with the events."
         }
       },
       "required": [
@@ -1911,6 +1908,7 @@
     },
     "EventHubEventSourceUpdateParameters": {
       "type": "object",
+      "x-ms-discriminator-value": "Microsoft.EventHub",
       "properties": {
         "properties": {
           "x-ms-client-flatten": true,
@@ -1926,6 +1924,7 @@
       "description": "Parameters supplied to the Update Event Source operation to update an EventHub event source."
     },
     "IoTHubEventSourceUpdateParameters": {
+      "x-ms-discriminator-value": "Microsoft.IoTHub",
       "type": "object",
       "properties": {
         "properties": {
@@ -1995,7 +1994,7 @@
       "description": "An event source that receives its data from an Azure EventHub."
     },
     "IoTHubEventSourceResource": {
-      "x-ms-discriminator-value": "Microsoft.IotHub",
+      "x-ms-discriminator-value": "Microsoft.IoTHub",
       "properties": {
         "properties": {
           "x-ms-client-flatten": true,
@@ -2160,9 +2159,7 @@
           "description": "An enum that represents the format of the local timestamp property that needs to be set.",
           "type": "string",
           "enum": [
-            "Embedded",
-            "Iana",
-            "TimeSpan"
+            "Embedded"
           ],
           "x-ms-enum": {
             "name": "LocalTimestampFormat",