Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StackOverflowException when retrieving document node on UWP platform #382

Closed
ooikengsiang opened this issue Mar 12, 2020 · 6 comments
Closed
Assignees

Comments

@ooikengsiang
Copy link

Description

StackOverflowException when retrieving document node on UWP platform. This happen after nuget version 1.11.19. This has no effect on Xamarin Android / iOS that running the same piece of code.

Exception

Since the stack is overflowed, no stack trace is available.

Fiddle or Project

var doc = new HtmlDocument();
doc.LoadHtml(respondContent);
var productInfoNode = doc.DocumentNode.Descendants("div").FirstOrDefault(x => x.GetAttributeValue("class", null)?.Contains("product-info") ?? false);
if (productInfoNode != null) // crash
{
}

Further technical details

Nuget version 1.11.18 running perfectly fine on UWP.
Nuget version 1.11.22 have the same problem too.

@JonathanMagnan JonathanMagnan self-assigned this Mar 12, 2020
@JonathanMagnan
Copy link
Member

Hello @jon,

Do you think you could provide a project sample with this issue?

It will help my developer investigate the issue more efficiently.

At this moment, I don't; think we can do anything with this request unless we have the content of respondContent to reproduce the issue

We now always ask for a project sample even if the issue is easy to reproduce. As a free product, we must find some way to save time to offer an overall better experience for everyone and release fixes faster.

You can send it to: [email protected] if you need to keep the source private

Best Regards,

Jonathan


Performance Libraries
context.BulkInsert(list, options => options.BatchSize = 1000);
Entity Framework ExtensionsEntity Framework ClassicBulk OperationsDapper Plus

Runtime Evaluation
Eval.Execute("x + y", new {x = 1, y = 2}); // return 3
C# Eval FunctionSQL Eval Function

@ooikengsiang
Copy link
Author

@mrjfalk
Copy link

mrjfalk commented Mar 22, 2020

I've also ran into StackOverflow issues in 1.11.22 on UWP, but after reading this post I downgraded to 1.11.18 and it all works fine again. Unfortunatly I don't have a simple reproducable project I can share at the moment.

@JonathanMagnan
Copy link
Member

Hello @ooikengsiang , @mrjfalk ,

The v1.11.23 has been released.

This new version should fix the issue with the method GetAttributeValue that causes this StackOverflow Exception.

Let me know if everything works as expected with the latest version.

@ooikengsiang
Copy link
Author

@JonathanMagnan v1.11.23 working as intended.
Thank you so much for the quick fix and update.

@mrjfalk
Copy link

mrjfalk commented Mar 23, 2020

Thanks, fixed the bug for me as well :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants