Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change using _ for private vars to use Symbols instead #11

Open
eudaimos opened this issue Jan 16, 2019 · 0 comments
Open

Change using _ for private vars to use Symbols instead #11

eudaimos opened this issue Jan 16, 2019 · 0 comments
Labels
api constistency enhancement to make the API consistent pkg: core corresponds to the @tao.js/core package pkg: react corresponds to the @tao.js/react package pkg: router corresponds to the @tao.js/router package pkg: socket.io corresponds to the @tao.js/socket.io package

Comments

@eudaimos
Copy link
Contributor

Self-explanatory, but to get it out the door I didn't use Symbols to hide internals.
Now that there are tests covering the API, we should switch to using Symbols for internal value tracking instead of the _ convention which doesn't actually hide the implementation details.
@eudaimos eudaimos added api constistency enhancement to make the API consistent pkg: core corresponds to the @tao.js/core package pkg: react corresponds to the @tao.js/react package pkg: socket.io corresponds to the @tao.js/socket.io package pkg: router corresponds to the @tao.js/router package labels Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api constistency enhancement to make the API consistent pkg: core corresponds to the @tao.js/core package pkg: react corresponds to the @tao.js/react package pkg: router corresponds to the @tao.js/router package pkg: socket.io corresponds to the @tao.js/socket.io package
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eudaimos