Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change dependency path from "per project" to "per dependency"
ZYDIS_ZYCORE_PATH
->ZYAN_ZYCORE_PATH
...
This way we do not need to change multiple path variables when a dependency is used multiple times. E.g. in case of
Zyrex
:./dependencies/zycore
[ZYREX_ZYCORE_PATH
])./dependencies/zydis
[ZYREX_ZYDIS_PATH
])./dependencies/zydis/dependencies/zycore
[ZYDIS_ZYCORE_PATH
])After my change there is only one
Zycore
path pointing to the top-level dependency:./dependencies/zycore
[ZYAN_ZYCORE_PATH
])./dependencies/zydis
[ZYAN_ZYDIS_PATH
])./dependencies/zycore
[ZYAN_ZYCORE_PATH
])Only negative point: This prevents the user to intentionally choose different dependency versions for individual sub-dependencies. I don' think this is really needed tho and as well to fully support that (at least for Windows shared builds) we would have to add a version suffix to the generated
.dll
files.