Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coverity complains about likely NPE in zycore #20

Open
lars-t-hansen opened this issue Jan 15, 2020 · 1 comment
Open

Coverity complains about likely NPE in zycore #20

lars-t-hansen opened this issue Jan 15, 2020 · 1 comment
Labels
A-container Area: Container classes P-low Priority: Low

Comments

@lars-t-hansen
Copy link
Contributor

I just pulled a recent zydis (4d4fe4c293c5438f32688b14b29017ae3f48369e) into Firefox. We run Coverity in the background on everything, and Coverity throws up a potential problem in zycore, the report is here: https://phabricator.services.mozilla.com/D59915#inline-364191. I have not tried to substantiate whether this is an actual problem, and we don't ship zydis in release builds so it's not a security issue for us, but perhaps you want to look into it.
@athre0z
Copy link
Member

athre0z commented Jan 16, 2020

Thanks for letting us know -- we'll look into it!

This portion of Zycore is not used in Zydis (or any other zyantific project that has been published yet), so impact should be low.

@athre0z athre0z added A-container Area: Container classes P-low Priority: Low labels Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-container Area: Container classes P-low Priority: Low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lars-t-hansen @athre0z