Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support H boxes with arbitrary complex labels #167

Open
RazinShaikh opened this issue Oct 8, 2023 · 3 comments
Open

Support H boxes with arbitrary complex labels #167

RazinShaikh opened this issue Oct 8, 2023 · 3 comments

Comments

@RazinShaikh
Copy link
Contributor

RazinShaikh commented Oct 8, 2023

Similar to the complex labels of the Z box that are now supported

@jvdwetering
Copy link
Collaborator

Since H-boxes also work with the current phase infrastructure, where a Fraction is used to represent a complex phase, I'm not sure what the best way to do this would be.

@dlyongemallo
Copy link
Contributor

Can you clarify a bit more about what the difficulty is?

@jvdwetering
Copy link
Collaborator

The way the complex phases currently work in Z-Boxes is that they use the vertexdata field instead of the phase field. Using a phase on Z-boxes is then considered to be ill-formed. The complexity is that the logic using H-boxes uses phases and not the vertexdata field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants