fix: propertyKey may be zero #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 587442100
💛 - Coveralls |
|
I can confirm this does indeed fix the issue described above. Also, when in combination with 1782 I can now fully and properly control my Inovelli Ilumin bulbs, which have RGB and WW and CW channels. |
This was referenced Feb 22, 2021
varet80
approved these changes
Feb 22, 2021
|
I found the same issue, @AlCalzone you where faster submitting. ;) |
|
Oh damn, thanks @AlCalzone ! |
|
@robertsLando I am closing PR #655 as it fixes the same thing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the missing color channel 0 for Color Switch CC and avoids value clashes between all values and color 0 when zwave-js/node-zwave-js#1782 is merged.