[fix] Detail on naming - Notifications Names #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 434514269
💛 - Coveralls |
ahochsteger
pushed a commit
that referenced
this pull request
Dec 27, 2020
BREAKING CHANGE: entities names could change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple times happens on notification names during discovery to have a name like:
It would be better if these names where:
This tries to avoid using the "duplicate" name by setting on Notifications the propertyKey
Also this happens with betteries, and other endpoints. when duplication happens. It is good idea to use endpoint number as extension instead of "repeating" the same property name.