Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: revert PR #920 "use prefixed node.id in mqtt discovery topic" #951

Merged
merged 1 commit into from
Mar 26, 2021
Merged

fix: revert PR #920 "use prefixed node.id in mqtt discovery topic" #951

merged 1 commit into from
Mar 26, 2021

Conversation

robertsLando
Copy link
Member

This reverts PR #920

@robertsLando robertsLando changed the title fix: revert PR ##920 "use prefixed node.id in mqtt discovery topic" fix: revert PR #920 "use prefixed node.id in mqtt discovery topic" Mar 26, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 689167920

  • 2 of 4 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.006%) to 18.14%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/Gateway.js 2 4 50.0%
Totals Coverage Status
Change from base Build 686577056: -0.006%
Covered Lines: 2026
Relevant Lines: 11454
💛 - Coveralls

@robertsLando robertsLando merged commit 2595701 into master Mar 26, 2021
@robertsLando robertsLando deleted the revert-discovery-name branch March 26, 2021 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robertsLando @coveralls