Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): redirects to main when auth is disabled #854

Merged
merged 2 commits into from
Mar 9, 2021
Merged

fix(ui): redirects to main when auth is disabled #854

merged 2 commits into from
Mar 9, 2021

Conversation

robertsLando
Copy link
Member

Fixes #675

@coveralls
Copy link

coveralls commented Mar 9, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 636028615

  • 0 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.006%) to 18.373%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/router/index.js 0 4 0.0%
Totals Coverage Status
Change from base Build 635789000: -0.006%
Covered Lines: 2026
Relevant Lines: 11307
💛 - Coveralls

@robertsLando
Copy link
Member Author

Unfortunaly this breaks the refrsh when auth is enabled 😢

@robertsLando
Copy link
Member Author

Tricky solutions but didn't find anything better. Now this works for both auth and no-auth environments 🎉

@robertsLando robertsLando merged commit 8f4f181 into master Mar 9, 2021
@robertsLando robertsLando deleted the fix#675 branch March 9, 2021 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] Page deep-links and browser reloads always switch to control panel
2 participants
@robertsLando @coveralls