Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bug when importing nodes.json #768

Merged
merged 1 commit into from
Mar 1, 2021
Merged

fix: bug when importing nodes.json #768

merged 1 commit into from
Mar 1, 2021

Conversation

osenft
Copy link
Contributor

@osenft osenft commented Feb 28, 2021

Fixes #767

@zwave-js-assistant
Copy link

🚧 It seems like this PR has lint errors 🚧

I should be able to fix them for you. If you want me to, just comment
@zwave-js-bot fix lint

@osenft osenft changed the title Convert nodId to number in importConfig before calling API Convert nodeId to number in importConfig before calling API Feb 28, 2021
@zwave-js-assistant
Copy link

🚧 It seems like this PR has lint errors 🚧

I should be able to fix them for you. If you want me to, just comment
@zwave-js-bot fix lint

@osenft osenft changed the title Convert nodeId to number in importConfig before calling API fix: Convert nodeId to number in importConfig before calling API Feb 28, 2021
@osenft
Copy link
Contributor Author

osenft commented Feb 28, 2021

@zwave-js-bot fix lint

@zwave-js-assistant
Copy link

🚧 It seems like this PR has lint errors 🚧

I should be able to fix them for you. If you want me to, just comment
@zwave-js-bot fix lint

@osenft
Copy link
Contributor Author

osenft commented Feb 28, 2021

@zwave-js-bot fix lint

@coveralls
Copy link

coveralls commented Feb 28, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 606900360

  • 0 of 5 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 18.801%
Changes Missing Coverage Covered Lines Changed/Added Lines %
app.js 0 5 0.0%
Totals Coverage Status
Change from base Build 602502207: -0.003%
Covered Lines: 2004
Relevant Lines: 10940
💛 - Coveralls

@osenft osenft changed the title fix: Convert nodeId to number in importConfig before calling API fix: convert nodeId to number in importConfig before calling API Feb 28, 2021
robertsLando
robertsLando approved these changes Mar 1, 2021
View reviewed changes
Copy link
Member

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @osenft

@robertsLando robertsLando changed the title fix: convert nodeId to number in importConfig before calling API fix: bug when importing nodes.json Mar 1, 2021
@robertsLando robertsLando merged commit 84550f2 into zwave-js:master Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertsLando robertsLando robertsLando approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] Cannot import nodes.json that was previously exported.
3 participants
@osenft @coveralls @robertsLando