-
-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: split prioritized CCs and discover first #625
Conversation
Pull Request Test Coverage Report for Build 581463131
💛 - Coveralls |
Co-authored-by: Daniel Lando <[email protected]>
Co-authored-by: Daniel Lando <[email protected]>
lib/Constants.js
Outdated
priorityCommandClass: [ | ||
51 // Color Switch | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to move this const inside the function getPriorityCCFirst
on gateway side for now, and instead of hard coding the 51 use the zwavejs COmmandClasses struct (like we do in the switch case in discover value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR tries to help dependent CCs to be discovered first.