Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: split prioritized CCs and discover first #625

Merged
merged 26 commits into from
Feb 19, 2021

Conversation

varet80
Copy link
Collaborator

@varet80 varet80 commented Feb 18, 2021

This PR tries to help dependent CCs to be discovered first.

  • Add Constant to allow easy addition of priority CCs
  • add a small function to create split list
  • iterate through the list

@varet80 varet80 requested a review from robertsLando February 18, 2021 18:30
@coveralls
Copy link

coveralls commented Feb 18, 2021

Pull Request Test Coverage Report for Build 581463131

  • 13 of 25 (52.0%) changed or added relevant lines in 1 file are covered.
  • 10 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 19.388%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/Gateway.js 13 25 52.0%
Files with Coverage Reduction New Missed Lines %
lib/Gateway.js 10 20.3%
Totals Coverage Status
Change from base Build 581171326: 0.1%
Covered Lines: 2027
Relevant Lines: 10724

💛 - Coveralls

lib/Gateway.js Outdated Show resolved Hide resolved
lib/Gateway.js Outdated Show resolved Hide resolved
lib/Gateway.js Outdated Show resolved Hide resolved
lib/Gateway.js Outdated Show resolved Hide resolved
@varet80 varet80 requested a review from robertsLando February 19, 2021 08:35
@varet80
Copy link
Collaborator Author

varet80 commented Feb 19, 2021

This is part of multiple PRs to solve the RGBW

this first PR is to increase HASS flexibility and tries to partially solve : #595 #477 and #351

After that another pr will introduce an improved Color Switch

lib/Gateway.js Outdated Show resolved Hide resolved
lib/Gateway.js Outdated Show resolved Hide resolved
varet80 and others added 2 commits February 19, 2021 09:42
Co-authored-by: Daniel Lando <[email protected]>
Co-authored-by: Daniel Lando <[email protected]>
@varet80 varet80 requested a review from robertsLando February 19, 2021 08:47
lib/Constants.js Outdated
Comment on lines 62 to 64
priorityCommandClass: [
51 // Color Switch
],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to move this const inside the function getPriorityCCFirst on gateway side for now, and instead of hard coding the 51 use the zwavejs COmmandClasses struct (like we do in the switch case in discover value

Copy link
Member

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robertsLando robertsLando merged commit e238ae1 into master Feb 19, 2021
@robertsLando robertsLando deleted the feat-gateway-priority-cc branch February 19, 2021 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants