Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(chore): dockerfile.contrib use slim for runtime, also clean devices index #618

Merged
merged 2 commits into from
Feb 18, 2021
Merged

fix(chore): dockerfile.contrib use slim for runtime, also clean devices index #618

merged 2 commits into from
Feb 18, 2021

Conversation

jcam
Copy link
Contributor

@jcam jcam commented Feb 18, 2021

  • The devices index.json should be generated at run time, any index in the tree is likely out of date.
  • do not need full erbium for runtime

@coveralls
Copy link

coveralls commented Feb 18, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 578764560

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 19.275%
Totals Coverage Status
Change from base Build 578760476: 0.0%
Covered Lines: 2009
Relevant Lines: 10694
💛 - Coveralls

robertsLando
robertsLando approved these changes Feb 18, 2021
View reviewed changes
Copy link
Member

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robertsLando robertsLando merged commit f4ff24a into zwave-js:master Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertsLando robertsLando robertsLando approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcam @coveralls @robertsLando