Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: correctly parse currentColor value and improve rgb discovery #568

Merged
merged 84 commits into from
Feb 26, 2021

Conversation

varet80
Copy link
Collaborator

@varet80 varet80 commented Feb 12, 2021

Z-wave gives posibility to manage RGB WW and CW on devices.
Each device has these channels separately.

Currently all devices has 5 channels or less (RGBWWCW, RGBW, RGB)

As devices (bulbs) manage RGB, WW and CW separately. there is no easy way to bind this with HASS
Hass light entity supports:

  1. On/OFF
  2. Dimmer
  3. RGB
  4. White Temperature
  5. HS, WX and some other features

the split WW/CW do not allow us to us the same entity for RGB and for Whites.

This patch implements:

  • RGB with brightness OR switch (depends on what exists)
  • Dimmer for both Whites (Cold and Warm)

Some devices support change of Warm white or cold white through Configuration Param. I will review if this is feseable to also supported.

fixes #477 #381 #351 #595

@varet80 varet80 changed the title DRAFT: Work on Rgbw switches fix: draft: work on rgbw switches Feb 12, 2021
@coveralls
Copy link

coveralls commented Feb 12, 2021

Pull Request Test Coverage Report for Build 602472119

  • 25 of 99 (25.25%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 18.804%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/ZwaveClient.js 0 4 0.0%
types/index.d.ts 0 6 0.0%
lib/Gateway.js 22 86 25.58%
Files with Coverage Reduction New Missed Lines %
lib/Gateway.js 1 19.81%
Totals Coverage Status
Change from base Build 602357398: -0.2%
Covered Lines: 2004
Relevant Lines: 10938

💛 - Coveralls

@robertsLando
Copy link
Member

@billiaz Works?

@varet80
Copy link
Collaborator Author

varet80 commented Feb 15, 2021

Not fully tested, I am waiting for a Bulb to arrive! lets keep it as "draft" for now"

@scyto
Copy link
Contributor

scyto commented Feb 26, 2021 via email

@zwave-js-assistant
Copy link

🚧 It seems like this PR has lint errors 🚧

I should be able to fix them for you. If you want me to, just comment
@zwave-js-bot fix lint

@zwave-js-assistant
Copy link

🚧 It seems like this PR has lint errors 🚧

I should be able to fix them for you. If you want me to, just comment
@zwave-js-bot fix lint

1 similar comment
@zwave-js-assistant
Copy link

🚧 It seems like this PR has lint errors 🚧

I should be able to fix them for you. If you want me to, just comment
@zwave-js-bot fix lint

@zwave-js-assistant
Copy link

🚧 It seems like this PR has lint errors 🚧

I should be able to fix them for you. If you want me to, just comment
@zwave-js-bot fix lint

@zwave-js-assistant
Copy link

🚧 It seems like this PR has lint errors 🚧

I should be able to fix them for you. If you want me to, just comment
@zwave-js-bot fix lint

@zwave-js-assistant
Copy link

🚧 It seems like this PR has lint errors 🚧

I should be able to fix them for you. If you want me to, just comment
@zwave-js-bot fix lint

@zwave-js-assistant
Copy link

🚧 It seems like this PR has lint errors 🚧

I should be able to fix them for you. If you want me to, just comment
@zwave-js-bot fix lint

@zwave-js-assistant
Copy link

🚧 It seems like this PR has lint errors 🚧

I should be able to fix them for you. If you want me to, just comment
@zwave-js-bot fix lint

@robertsLando robertsLando changed the title fix: rework rgbw switches - read description for hass and rgb feat: correctly parse currentColor value and improve rgb discovery Feb 26, 2021
@robertsLando robertsLando merged commit 7bedd3b into master Feb 26, 2021
@robertsLando robertsLando deleted the rgbw_switch branch February 26, 2021 10:45
@thundergreen
Copy link

Do we have to re-interview the RGB devices? At the momont I am not able to test as lastest HASS beta version Home Assistant 2021.3.0b1 breaks Z-Wave JS to MQTT (b897934) as stated here: hassio-addons/addon-zwave-js-ui#58

Hope there will be a fix soon and that we can finally properly use our RGB lights with color wheel as expected :) Thanks a lot for this efforts here! TOP

@robertsLando
Copy link
Member

robertsLando commented Feb 26, 2021

Do we have to re-interview the RGB devices

Yes. Update to version 2.0.0 and this should work

@thundergreen
Copy link

Just updated to version 2.0.0 via Hassio ADDOn but my rgb controller still has one switch for each color. What steps are neccessairy to get this rgb running? i tried re-nterview but without success. :( Any hint. ?

@robertsLando
Copy link
Member

@thundergreen If you are usiung zwavejs integration this will have no effect as here we fixed mqtt discovery

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Zipato v2 rgb not showing/working colors
7 participants