-
-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: barrier operator hass replace barrier states with integers #556
Conversation
Pull Request Test Coverage Report for Build 588667991
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a code side, LGTM
@billiaz can we merge this? |
no, there is a small issue I want to discuss with reporter of this! as it is a state we need to cover. |
@robertsLando merged fresh master branch to this project |
@billiaz Is this ready to be merged? |
I think yes. But I want to be sure for one details about the unknown state. Looking on possible "if" statement |
@robertsLando it is good for now |
Tell me when it's ready to merge so :) |
@billiaz ? |
Updated from Master, ready to be merged back to master after this, if no problems found in linting |
How does the The Barrier Operator CC Set command does not have a stop value, only open and close. My understanding was that the only way to stop a cover is issuing an open command when it's in the closing state. |
@billiaz ? |
Hmm that becomes tricky.... @robertsLando @kpine One thought @robertsLando is to program a function in Zwavejs2mqtt, if this is the state and a stop command comes in, to execute the proper in driver... |
@billiaz multilevel CC has startLevelChange and stopLevelChange, in writeValue function I have handle them by checking if the CC is multilevel switch and the payload is |
Thanks @robertsLando for pointing out @kpine I look into doing it in a few days and testing. Is this ok? (usually few days is ~4 days) |
Well, it was more of a question. I implemented the Barrier Operator support for the cover platform in Home Assistant, and from looking at the z-wave specs and the node-zwave-js API, there is no Stop command, so I did not implement support for it. The spec also shows that you stop the cover only when it's closing, using an Open command. I was following the work here and noticed that you added the |
This PR tries to fix #555
We need to test it before implementing it
@ratsputin can you try it?