Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: socket manager and better application startup #51

Merged
merged 6 commits into from
Dec 4, 2020
Merged

feat: socket manager and better application startup #51

merged 6 commits into from
Dec 4, 2020

Conversation

robertsLando
Copy link
Member

No description provided.

@robertsLando robertsLando changed the title fix: application startup flow feat: socket manager and better application startup Dec 4, 2020
@robertsLando robertsLando mentioned this pull request Dec 4, 2020
Merged
23 tasks
@coveralls
Copy link

coveralls commented Dec 4, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 400781705

  • 57 of 219 (26.03%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.6%) to 27.929%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/ZwaveClient.js 0 1 0.0%
lib/Gateway.js 1 5 20.0%
lib/SocketManager.js 56 89 62.92%
app.js 0 124 0.0%
Totals Coverage Status
Change from base Build 400262976: 0.6%
Covered Lines: 1857
Relevant Lines: 6767
💛 - Coveralls

@robertsLando robertsLando merged commit 19e6ac4 into master Dec 4, 2020
@robertsLando robertsLando deleted the fix#startupFlow branch December 4, 2020 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robertsLando @coveralls