Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): settings labels #482

Merged
merged 1 commit into from
Feb 8, 2021
Merged

Conversation

towerhand
Copy link
Contributor

@towerhand towerhand commented Feb 6, 2021

Issue #472

Temp "fix"

I'm thinking the settings panel needs to be rearranged a little.

This setting for example should be enable to enable instead of enable to disable.

Also, I'm thinking the settings should be:

  • General
  • Zwave
  • Enable WS server. (instead of inside of Zwave) (show the relevant options if toggle on)
  • Enable MQTT Gateway. (show the relevant options if if toggle on) (opposite behavior from current)

Seems like an easy change so if you like the idea I'll figure out how to do it and submit another PR.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 543309716

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 20.766%

Totals Coverage Status
Change from base Build 542943065: 0.0%
Covered Lines: 1996
Relevant Lines: 9852

💛 - Coveralls

Copy link
Collaborator

@jarrettv jarrettv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree we need to revamp settings but this is a good tweak for now

@towerhand towerhand changed the title feat(ui): Add MQTT to the Disable Gateway label feat(ui): add MQTT to the Disable Gateway label Feb 7, 2021
@towerhand towerhand changed the title feat(ui): add MQTT to the Disable Gateway label feat(ui): add MQTT to the disable gateway label Feb 7, 2021
@towerhand towerhand changed the title feat(ui): add MQTT to the disable gateway label feat(ui): add mqtt to the disable gateway label Feb 7, 2021
@robertsLando robertsLando changed the title feat(ui): add mqtt to the disable gateway label fix(ui): settings labels Feb 7, 2021
@robertsLando
Copy link
Member

@towerhand Could you show me your idea?

@towerhand
Copy link
Contributor Author

If you would like let's merge this, I have to figure out how to create a mock up to show you and make the changes I'm thinking about.

@robertsLando robertsLando merged commit d69560f into zwave-js:master Feb 8, 2021
@towerhand towerhand deleted the patch-2 branch February 10, 2021 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants