Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] crash when refreshing /settings and /mesh #42

Closed
2 of 3 tasks
larstobi opened this issue Dec 1, 2020 · 2 comments
Closed
2 of 3 tasks

[bug] crash when refreshing /settings and /mesh #42

larstobi opened this issue Dec 1, 2020 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@larstobi
Copy link
Contributor

larstobi commented Dec 1, 2020

Version

Build/Run method

  • Docker
  • PKG
  • Manually built (git clone - npm install - npm run build )

zwavejs2mqtt version: c762a85 (master)

Describe the bug
When I click on the settings icon, I am sent to /settings. This works. If I then click refresh page, it crashes. The same happens with /mesh.

To Reproduce
Steps to reproduce the behavior:

  1. Click on the settings symbol.
  2. Click refresh page on your browser
  3. See crash error:
Error: Not Found
    at /usr/src/app/app.js:255:15
    at Layer.handle [as handle_request] (/usr/src/app/node_modules/express/lib/router/layer.js:95:5)
    at trim_prefix (/usr/src/app/node_modules/express/lib/router/index.js:317:13)
    at /usr/src/app/node_modules/express/lib/router/index.js:284:7
    at Function.process_params (/usr/src/app/node_modules/express/lib/router/index.js:335:12)
    at next (/usr/src/app/node_modules/express/lib/router/index.js:275:10)
    at /usr/src/app/node_modules/connect-history-api-fallback/lib/index.js:85:5
    at Layer.handle [as handle_request] (/usr/src/app/node_modules/express/lib/router/layer.js:95:5)
    at trim_prefix (/usr/src/app/node_modules/express/lib/router/index.js:317:13)
    at /usr/src/app/node_modules/express/lib/router/index.js:284:7
    at Function.process_params (/usr/src/app/node_modules/express/lib/router/index.js:335:12)
    at next (/usr/src/app/node_modules/express/lib/router/index.js:275:10)
    at cors (/usr/src/app/node_modules/cors/lib/index.js:188:7)
    at /usr/src/app/node_modules/cors/lib/index.js:224:17
    at originCallback (/usr/src/app/node_modules/cors/lib/index.js:214:15)
    at /usr/src/app/node_modules/cors/lib/index.js:219:13

Expected behavior
The same page should load correctly.

@larstobi larstobi added the bug Something isn't working label Dec 1, 2020
@robertsLando
Copy link
Member

@larstobi That should be handled by connect-history-api-fallback, let me investigate what's happening

robertsLando added a commit that referenced this issue Dec 1, 2020
@robertsLando
Copy link
Member

robertsLando commented Dec 1, 2020

@larstobi FIxed! This has been broken some months ago in z2m by a user PR, strange no one has never reported it before now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants