Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): labels and mobile view #413

Merged
merged 13 commits into from
Feb 3, 2021
Merged

fix(ui): labels and mobile view #413

merged 13 commits into from
Feb 3, 2021

Conversation

robertsLando
Copy link
Member

@robertsLando robertsLando commented Feb 1, 2021

  • Better labels
  • Fix expandable menu on mobile devices
  • Table horizontal scroll on overflow

Fixes #399

cc @blhoward2

@robertsLando robertsLando changed the title fix: better values labels fix(ui): labels and mobile view Feb 1, 2021
@robertsLando
Copy link
Member Author

@ahochsteger

@coveralls
Copy link

coveralls commented Feb 1, 2021

Pull Request Test Coverage Report for Build 533308721

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 20.725%

Totals Coverage Status
Change from base Build 533291396: 0.0%
Covered Lines: 1981
Relevant Lines: 9799

💛 - Coveralls

@robertsLando
Copy link
Member Author

@ahochsteger For some reasons seems that the v-select isn't respecting display breakpoints, I fixed byt setting a max-width on that for now

@robertsLando
Copy link
Member Author

robertsLando commented Feb 1, 2021

There is definetly some bugs in the grid system. Need to figure out what's going on there

Everything seems working correctly on xs and md screens, not so good with sm

@robertsLando
Copy link
Member Author

@ahochsteger Ok I have found the problem. It happens when the view is between 600 (mobile breakpoint for data table) and 1200px. In this case the table hasn't enought space to show all columns so it adds an horiontal scroll that results in wrong widths in the expanded item too. We should find a way to prevent this

@robertsLando
Copy link
Member Author

@ahochsteger This problems

@robertsLando
Copy link
Member Author

@ahochsteger Switched to the new grid system 🎉

@ahochsteger
Copy link
Collaborator

@robertsLando great!
And does it solve some of the UI problems?

@robertsLando
Copy link
Member Author

And does it solve some of the UI problems?

Nope, btw wasn't that the reason why I did it. To fix them we should check the available width and make the table not scrollable horizontally

@robertsLando robertsLando merged commit cb2d735 into master Feb 3, 2021
@robertsLando robertsLando deleted the ui-fixes branch February 3, 2021 08:35
@robertsLando
Copy link
Member Author

Merging this for now, will look at others ui problems in another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Can't scroll device horizontally without opening home assistant tab
3 participants