-
-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): show/hide node table columns #407
Conversation
Pull Request Test Coverage Report for Build 530128304
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Easy clean and useful. Thanks :)
@ahochsteger Feel free to squash and merge once ready |
@robertsLando thanks for your feedback! Are you ok with the defaults I've chosen to not show certain columns by default? |
@ahochsteger I would keep all visible by default, and also I would store the shown in localstorage (like for the filters etc) |
@robertsLando the list of columns is now stored in local storage and the full list of headers is shown by default. |
@ahochsteger In order to fix the UI problems I think we could set a max number of columns based on the screen size. What do you think about this? |
@robertsLando I'm not sure, if the number of columns is a good solution here if you compare the width of the "ID" column with the "Product" column that shows for example something like "A real push button (switch) available in several colors." (which should be reduced in the device config anyway). |
@ahochsteger What other solution do you propose to fix the other UI problem? |
I'm not sure, which "other" UI problem you are referring to in this context? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR provides the possibility to show / hide individual table columns.
Button to show the selection menu:
Menu to choose the columns from:
The headers array allows to customize each column using the properties
active
(is currently visible or not) andselectable
(is selectable in the menu or not).Some not so important columns are now not shown by default (see screenshot above).
Since this reflects my personal opinion I'm interested in feedback, what the defaults should be.
It lays the foundation to provide much more data in the nodes table (e.g. battery level, ...) without overloading the number of columns.