Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] gateway device dropdown does not include devices in RestartFromCache interview stage #394

Closed
1 of 3 tasks
jonathan-reisdorf opened this issue Jan 30, 2021 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@jonathan-reisdorf
Copy link

jonathan-reisdorf commented Jan 30, 2021

Before submitting a bug please read: https://zwave-js.github.io/zwavejs2mqtt/#/troubleshooting/bug_report

Version

Build/Run method

  • Docker
  • PKG
  • Manually built (git clone - npm install - npm run build )

zwavejs2mqtt version: latest master (1.0.1)
zwavejs version: 6.1.0

Describe the bug

Not sure if that's already been brought up, but when adding or modifying values in the gateway section, the device dropdown does not include devices in RestartFromCache interview stage, only those from Complete stage. So, passive devices are unfortunately not available right away in that dropdown e.g. after restart or after saving the gateway settings, which seems to trigger a reset.

To Reproduce

Steps to reproduce the behavior:

  1. Go to Settings > Gateway
  2. Click on 'New Value'
  3. Device dropdown does not contain devices currently in RestartFromCache stage

Expected behavior

If possible, it would be very helpful if all devices from cache could be included as well so we can add gateway values right away. If that's not feasible, a small help text would be great explaining that only devices in completed interview stage are available.

Additional context

Thanks for your work!

@jonathan-reisdorf jonathan-reisdorf added the bug Something isn't working label Jan 30, 2021
@robertsLando
Copy link
Member

@jonathan-reisdorf Devices are added only when the interview completes. The reason is that only on that stage I'm completely sure all values are there

@jonathan-reisdorf
Copy link
Author

Thanks. I guess then unless we have a way of also caching/persisting the values from last time when the interview was completed, the only thing we can do here is show a small hint so that others know they have to wake up their passive device first in order for it to show up in the list.

@robertsLando
Copy link
Member

@jonathan-reisdorf Made it more clear in docs :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants