Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): inconsistent, unsorted node selection #258

Merged
merged 2 commits into from
Jan 17, 2021

Conversation

ahochsteger
Copy link
Collaborator

If you have a large number of nodes it is not easy to find the relevant ones in the selection list.
Therefore I suggest to sort them by display name (using _name).

Affected selections:

  • groups: node and target selection
  • scenes: node selection

In addition, the node selection in the scenes tab did not filter failed nodes, which has been changed for consistency too.

* groups: node and target selection
* secenes: node selection
@coveralls
Copy link

coveralls commented Jan 17, 2021

Pull Request Test Coverage Report for Build 491599470

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 23.644%

Totals Coverage Status
Change from base Build 488283300: 0.0%
Covered Lines: 1957
Relevant Lines: 8455

💛 - Coveralls

src/components/ControlPanel.vue Outdated Show resolved Hide resolved
src/components/ControlPanel.vue Outdated Show resolved Hide resolved
src/components/dialogs/DialogSceneValue.vue Outdated Show resolved Hide resolved
Copy link
Member

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robertsLando robertsLando merged commit f8042ed into master Jan 17, 2021
@robertsLando robertsLando deleted the sort-nodes-in-groups-select branch January 17, 2021 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants