Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: zwave-js server support #248

Merged
merged 10 commits into from
Jan 19, 2021
Merged

feat: zwave-js server support #248

merged 10 commits into from
Jan 19, 2021

Conversation

robertsLando
Copy link
Member

No description provided.

balloob
balloob previously approved these changes Jan 16, 2021
@ahochsteger
Copy link
Collaborator

@robertsLando would this be the solution to restart the UI of zwavejs2mqtt without re-discovering all nodes?
I guess the zwave-js server would then run in a separate Docker container than zwavejs2mqtt.
If there's something I can do to make this happen (e.g. do some tests or help with Docker setup) just let me know.

@balloob
Copy link

balloob commented Jan 18, 2021

@ahochsteger that is not what this PR is about. This is about also exposing a websocket connection for other applications that want access to the Z-Wave JS driver.

@ahochsteger
Copy link
Collaborator

@balloob ah, I see - thanks for clarifying!

@coveralls
Copy link

coveralls commented Jan 18, 2021

Pull Request Test Coverage Report for Build 496446205

  • 0 of 17 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 23.535%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/store/mutations.js 0 3 0.0%
lib/ZwaveClient.js 0 14 0.0%
Totals Coverage Status
Change from base Build 496408693: -0.04%
Covered Lines: 1958
Relevant Lines: 8499

💛 - Coveralls

@robertsLando robertsLando merged commit 3ad9ee6 into master Jan 19, 2021
@robertsLando robertsLando deleted the zwave-js-server branch January 19, 2021 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants