Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use buttons for target value #133 #151

Merged
merged 5 commits into from
Jan 5, 2021
Merged

fix: use buttons for target value #133 #151

merged 5 commits into from
Jan 5, 2021

Conversation

robertsLando
Copy link
Member

@robertsLando robertsLando commented Jan 5, 2021

Fixes #133

Now switches are replaced by two buttons:

Schermata da 2021-01-05 09-59-11

@coveralls
Copy link

coveralls commented Jan 5, 2021

Pull Request Test Coverage Report for Build 463723180

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 25.415%

Totals Coverage Status
Change from base Build 463652907: 0.0%
Covered Lines: 1966
Relevant Lines: 7902

💛 - Coveralls

@aretakisv
Copy link
Contributor

This is nice!
What I wanted to also mention, although not covered here!

Level up and Level down buttons should be instant buttons and not on/off as it is press/release action
We should think it separately. but this solution is nice for true/false events

to fit with your ui colors, would different softer colors be an option?

@robertsLando
Copy link
Member Author

to fit with your ui colors, would different softer colors be an option?

Suggestion? As @AlCalzone said bool values are not stateless (at least not all) and to show the actual state I use the blue color.

If the actual state is true the ON will be blue and the OFF red.
If the actual state is false the ON will be green and the OFF blue.

@robertsLando
Copy link
Member Author

robertsLando commented Jan 5, 2021

I have fixed the style now. I prefer this:

Schermata da 2021-01-05 12-11-28

THis is when state is OFF, when ON the on button is filled and the OFF not

@robertsLando robertsLando merged commit 6da9a58 into master Jan 5, 2021
@robertsLando robertsLando deleted the fix#133 branch January 5, 2021 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] Target Value should be selectable by user
3 participants