Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow sendCommand to accept string command classes #1230

Merged
merged 1 commit into from
May 17, 2021
Merged

fix: allow sendCommand to accept string command classes #1230

merged 1 commit into from
May 17, 2021

Conversation

robertsLando
Copy link
Member

Fixes #1219

@robertsLando robertsLando requested a review from AlCalzone May 17, 2021 08:07
@coveralls
Copy link

Pull Request Test Coverage Report for Build 849021002

  • 0 of 7 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.006%) to 17.724%
Changes Missing Coverage Covered Lines Changed/Added Lines %
types/index.d.ts 0 1 0.0%
lib/ZwaveClient.js 0 6 0.0%
Totals Coverage Status
Change from base Build 848994031: -0.006%
Covered Lines: 2023
Relevant Lines: 11779
💛 - Coveralls

@robertsLando robertsLando merged commit a2e704c into master May 17, 2021
@robertsLando robertsLando deleted the feat#1219 branch May 17, 2021 12:02
AlCalzone
AlCalzone reviewed May 17, 2021
View reviewed changes
lib/ZwaveClient.js Show resolved Hide resolved
lib/ZwaveClient.js Show resolved Hide resolved
@robertsLando
Copy link
Member Author

@AlCalzone Implemented in a new PR, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlCalzone AlCalzone AlCalzone left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feat] Modify sendCommand to accept command class names in addition to CC IDs
3 participants
@robertsLando @coveralls @AlCalzone