Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: move docs to github pages using docsify #122

Merged
merged 13 commits into from
Jan 2, 2021
Merged

feat: move docs to github pages using docsify #122

merged 13 commits into from
Jan 2, 2021

Conversation

robertsLando
Copy link
Member

@robertsLando robertsLando commented Dec 30, 2020 •
edited
Loading

Fixes #119

TODOs

  • Check for broken links/images
  • Better split files
  • Use notations where possible

To see docs preview locally run npm install -g docsify-cli and then npm run docs

@coveralls
Copy link

coveralls commented Dec 30, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 457517978

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 25.46%
Totals Coverage Status
Change from base Build 457508880: 0.0%
Covered Lines: 1962
Relevant Lines: 7872
💛 - Coveralls

@robertsLando robertsLando requested review from chrisns and AlCalzone and removed request for ahochsteger December 30, 2020 15:10
@robertsLando robertsLando linked an issue Dec 30, 2020 that may be closed by this pull request
[feat] Move docs to github pages #119
Closed
@robertsLando robertsLando changed the title feat: move docs to docsify feat: move docs to github pages using docsify Dec 30, 2020
@AlCalzone
Copy link
Member

I didn't read it all in depth, but looks good at a first glance

varet80
varet80 approved these changes Dec 30, 2020
View reviewed changes
Copy link
Collaborator

@varet80 varet80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems really nice!

@robertsLando robertsLando merged commit 3e9425d into master Jan 2, 2021
@robertsLando robertsLando deleted the docsify branch January 2, 2021 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlCalzone AlCalzone AlCalzone approved these changes

@varet80 varet80 varet80 approved these changes

@chrisns chrisns Awaiting requested review from chrisns

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feat] Move docs to github pages
4 participants
@robertsLando @coveralls @AlCalzone @varet80