Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update node groups on node ready #1076

Merged
merged 1 commit into from
Apr 19, 2021
Merged

fix: update node groups on node ready #1076

merged 1 commit into from
Apr 19, 2021

Conversation

robertsLando
Copy link
Member

Fixes #1072

@robertsLando
Copy link
Member Author

@jmgiaever Could you give this a try?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 758161514

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 17.927%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/ZwaveClient.js 0 3 0.0%
Totals Coverage Status
Change from base Build 758154115: 0.0%
Covered Lines: 2030
Relevant Lines: 11614
💛 - Coveralls

@jmgiaever
Copy link
Contributor

Sure, thank you! I'm just compiling 3.4.0 first and push it to the latest snap-branch first.

(Is it Monday already? 😉 )

@jmgiaever
Copy link
Contributor

Seems to be working now. Great job! :)

@robertsLando robertsLando merged commit f7f960c into master Apr 19, 2021
@robertsLando robertsLando deleted the fix#1072 branch April 19, 2021 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] Need a fullpage refresh to get association groups populated for new devices
3 participants
@robertsLando @coveralls @jmgiaever