[feat] Hass: Add Translation of states list to value_template map and Notification Command Class first to use this #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 438698385
💛 - Coveralls |
varet80
changed the title
robertsLando
requested changes
Dec 22, 2020
lib/Gateway.js
Outdated
| @@ -1528,7 +1530,7 @@ Gateway.prototype.discoverValue = function (node, vId) { | |||
| if (valueId.list) { | |||
| cfg.discovery_payload.value_template = getMappedStateTemplate( | |||
| valueId.states, | |||
| 0 | |||
| valueId.default ? valueId.default : 0 | |||
There was a problem hiding this comment.
Just to be sure I understood this correctly, IMO when the value is not in the map the value shown should be the one coming from json payload. Id this what's happening here?
There was a problem hiding this comment.
I stand corrected. I did some nice patching on the payload, after manual testing
If valueId.default is undefinied the default value of payload is the value_json.value
this way it really presents the value numeric or other on UI
This was referenced Dec 23, 2020
3 tasks
ahochsteger
pushed a commit
that referenced
this pull request
Dec 27, 2020
* add notification part 1 * add translation from states to value_template * support both number and text * add motion sensor icon * add new icon for motion sensor * add TODO for icons. Add logic on mapped default value * patch default value, to show value_json.value when uknown mapping entry is posted * remove extra bracket * fix linting issues Co-authored-by: V. Aretakis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make Sensors of Notification CC provide translated values to Home assistant.
An example is Motion sensors. While the state is 0 or 8, this is not a nice to look into.
The real values per z-wave specification are idle and 'Motion detection'.
This patch converts the sensor values showin in HASS in human readable form.