Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): group values by command classes #103

Merged
merged 3 commits into from
Dec 21, 2020
Merged

feat(ui): group values by command classes #103

merged 3 commits into from
Dec 21, 2020

Conversation

robertsLando
Copy link
Member

@robertsLando robertsLando commented Dec 21, 2020

Fixes #79

Result:

Schermata da 2020-12-21 16-45-54

@coveralls
Copy link

Pull Request Test Coverage Report for Build 436119270

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 28.543%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/ZwaveClient.js 0 1 0.0%
Totals Coverage Status
Change from base Build 435391333: 0.05%
Covered Lines: 1937
Relevant Lines: 6930

💛 - Coveralls

@varet80
Copy link
Collaborator

varet80 commented Dec 21, 2020

I just love it!
thanks @robertsLando

@robertsLando robertsLando merged commit 306b380 into master Dec 21, 2020
@robertsLando robertsLando deleted the uiGroups branch December 21, 2020 19:56
ahochsteger pushed a commit that referenced this pull request Dec 27, 2020
* feat(ui): groups values by command class

* fix: remove genre from valueId

* fix: lint issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] Improve UI user values
3 participants