fix: Alarms hass discovery and undefined units bug #232 #231

zwave-js · Feb 3, 2020 · fa2b022 · fa2b022
1 parent 9e0102e
commit fa2b022
Showing 1 changed file with 8 additions and 11 deletions.
diff --git a/lib/Gateway.js b/lib/Gateway.js
@@ -858,15 +858,12 @@ Gateway.prototype.discoverValue = function (node, valueId) {
         break
       case 'alarm':
 
-        switch (valueId.index) {
-          case 0: cfg = 'sensor_alarm_type'
-            break
-          case 1: cfg = 'sensor_alarm_level'
-            break
-          case 10: cfg = 'sensor_alarm_burglar'
-            break
-          default:
-            return
+        if (valueId.index < 256) {
+          cfg = 'sensor_alarm_burglar'
+        } else if (valueId.index === 512) {
+          cfg = 'sensor_alarm_type'
+        } else if (valueId.index === 513) {
+          cfg = 'sensor_alarm_level'
         }
 
         if (cfg && hassCfg[cfg]) {
@@ -885,12 +882,12 @@ Gateway.prototype.discoverValue = function (node, valueId) {
           cfg = Constants.meterType(valueId.index)
         }
 
+        cfg = cfg ? copy(hassCfg[cfg]) : copy(hassCfg.sensor_generic)
+
         if (valueId.units) {
           cfg.discovery_payload.unit_of_measurement = valueId.units
         }
 
-        cfg = cfg ? copy(hassCfg[cfg]) : copy(hassCfg.sensor_generic)
-
         // check if there is a custom value configuration for this valueID
         if (valueConf) {
           if (valueConf.device_class) {