fix: duplicate nodestatus call in initNode

zwave-js · Dec 1, 2020 · a8a984b · a8a984b
1 parent 720a9c0
commit a8a984b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/lib/Gateway.js b/lib/Gateway.js
@@ -1155,7 +1155,7 @@ Gateway.prototype.discoverDevice = function (node, hassDevice) {
  */
 Gateway.prototype.discoverClimates = function (node) {
   // https://github.com/zwave-js/node-zwave-js/blob/master/packages/config/config/deviceClasses.json#L177
-  if (!node.deviceClass.generic === 0x08) {
+  if (!node.deviceClass || node.deviceClass.generic !== 0x08) {
     // it's a thermostat
     return
   }

diff --git a/lib/ZwaveClient.js b/lib/ZwaveClient.js
@@ -276,8 +276,6 @@ function onNodeReady (zwaveNode) {
   if (!node || node.ready) return
 
   node.ready = true
-  onNodeStatus.call(this, zwaveNode)
-
   initNode.call(this, zwaveNode)
 
   const values = zwaveNode.getDefinedValueIDs()
@@ -288,7 +286,7 @@ function onNodeReady (zwaveNode) {
 
   node.lastActive = Date.now()
 
-  this.emit('nodeStatus', node)
+  onNodeStatus.call(this, zwaveNode)
 
   this.emit('event', eventEmitter.node, 'node ready', this.nodes[zwaveNode.id])