fix: remove refreshNodeInfo and auto heal options (#603)

zwave-js · Jun 30, 2020 · 449b03a · 449b03a
1 parent 692017c
commit 449b03a
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 55 deletions.
diff --git a/README.md b/README.md
@@ -36,27 +36,28 @@ After a [discussion](https://github.com/OpenZWave/Zwave2Mqtt/issues/201) with Op
 ## 📖 Table of contents
 
 - [Zwave To MQTT](#zwave-to-mqtt)
-  - [!! ATTENTION !!](#-attention)
-  - [📖 Table of contents](#%f0%9f%93%96-table-of-contents)
-  - [:electric_plug: Installation](#electricplug-installation)
-    - [DOCKER :tada: way](#docker-tada-way)
+  - [!! ATTENTION](#-attention)
+  - [📖 Table of contents](#-table-of-contents)
+  - [:electric_plug: Installation](#-installation)
+    - [DOCKER :tada: way](#docker--way)
     - [Kubernetes way](#kubernetes-way)
     - [NodeJS or PKG version](#nodejs-or-pkg-version)
     - [Reverse Proxy Setup](#reverse-proxy-setup)
-  - [:nerd_face: Development](#nerdface-development)
-  - [:wrench: Usage](#wrench-usage)
+  - [:nerd_face: Development](#-development)
+    - [Developing against a different backend](#developing-against-a-different-backend)
+  - [:wrench: Usage](#-usage)
     - [Zwave](#zwave)
     - [MQTT](#mqtt)
     - [Gateway](#gateway)
       - [Special topics](#special-topics)
       - [Gateway values table](#gateway-values-table)
-  - [:file_folder: Nodes Management](#filefolder-nodes-management)
+  - [:file_folder: Nodes Management](#-nodes-management)
     - [Add a node](#add-a-node)
     - [Remove a node](#remove-a-node)
     - [Replace failed node](#replace-failed-node)
     - [Remove a failed node](#remove-a-failed-node)
-  - [:star: Features](#star-features)
-  - [:robot: Home Assistant integration (BETA)](#robot-home-assistant-integration-beta)
+  - [:star: Features](#️-features)
+  - [:robot: Home Assistant integration (BETA)](#-home-assistant-integration-beta)
     - [Components management](#components-management)
       - [Rediscover Node](#rediscover-node)
       - [Edit existing component](#edit-existing-component)
@@ -66,24 +67,24 @@ After a [discussion](https://github.com/OpenZWave/Zwave2Mqtt/issues/201) with Op
       - [Thermostats](#thermostats)
       - [Fans](#fans)
       - [Thermostats with Fans](#thermostats-with-fans)
-  - [:gift: MQTT APIs](#gift-mqtt-apis)
+  - [:gift: MQTT APIs](#-mqtt-apis)
     - [Zwave Events](#zwave-events)
       - [Example](#example)
     - [Zwave APIs](#zwave-apis)
       - [Custom APIs](#custom-apis)
     - [Set values](#set-values)
     - [Broadcast](#broadcast)
-  - [:camera: Screenshots](#camera-screenshots)
+  - [:camera: Screenshots](#-screenshots)
     - [Settings](#settings)
     - [Control Panel](#control-panel)
     - [Groups associations](#groups-associations)
     - [Scenes](#scenes)
     - [Mesh](#mesh)
     - [Debug](#debug)
   - [Health check endpoints](#health-check-endpoints)
-  - [:question: FAQ](#question-faq)
-  - [:pray: Thanks](#pray-thanks)
-  - [:pencil: TODOs](#pencil-todos)
+  - [:question: FAQ](#-faq)
+  - [:pray: Thanks](#-thanks)
+  - [:pencil: TODOs](#-todos)
   - [:bowtie: Author](#bowtie-author)
 
 ## :electric_plug: Installation
@@ -210,9 +211,6 @@ Zwave settings:
 - **Network key** (Optional): Zwave network key if security is enabled. The correct format is `"0xCA,0xFE,0xBA,0xBE,.... "` (16 bytes total)
 - **Logging**: Enable/Disable Openzwave Library logging
 - **Save configuration**: Store zwave configuration in `zwcfg_<homeHex>.xml` and `zwscene.xml` files this is needed for persistent node information like node name and location
-- **Refresh Node Info**: Enable this to automatically call `refreshNodeInfo` api against all nodes to force all nodes refreshing their configuration
-- **Auto Heal Network**: Enable this to schedule automatic network heals to a specfic time
-- **Heal hours**: When auto heal is enabled, specified the hours at which `healNetwork` will be daily triggered (0-23)
 - **Poll interval**: Interval in milliseconds between polls (should not be less than 1s per device)
 - **Commands timeout**: Seconds to wait before automatically stop inclusion/exclusion
 - **Configuration Path**: The path to Openzwave devices config db

diff --git a/lib/ZwaveClient.js b/lib/ZwaveClient.js
@@ -590,17 +590,12 @@ function scanComplete () {
   for (var i = 0; i < nodes.length; i++) {
     this.getGroups(nodes[i].node_id)
     nodes[i].neighborns = this.client.getNodeNeighbors(nodes[i].node_id)
-    if (this.cfg.refreshNodeInfo) {
-      this.client.refreshNodeInfo(nodes[i].node_id)
-    }
   }
 
   if (this.cfg.saveConfig && typeof this.client.writeConfig === 'function') {
     this.client.writeConfig()
   }
 
-  this.scheduleHeal()
-
   debug('Network scan complete. Found:', nodes.length, 'nodes')
 }
 

diff --git a/src/App.vue b/src/App.vue
@@ -22,12 +22,15 @@
           v-for="item in pages"
           :key="item.title"
           :to="item.path == '#' ? '' : item.path"
+          :color="item.path === $route.path ? 'primary' : ''"
         >
           <v-list-item-action>
             <v-icon>{{ item.icon }}</v-icon>
           </v-list-item-action>
           <v-list-item-content>
-            <v-list-item-title>{{ item.title }}</v-list-item-title>
+            <v-list-item-title class="subtitle-2 font-weight-bold">{{
+              item.title
+            }}</v-list-item-title>
           </v-list-item-content>
         </v-list-item>
         <v-list-item v-if="!mini">

diff --git a/src/components/Settings.vue b/src/components/Settings.vue
@@ -67,35 +67,6 @@
                           v-model="zwave.assumeAwake"
                         ></v-switch>
                       </v-flex>
-                      <v-flex xs12 sm6>
-                        <v-switch
-                          hint="Automatically call RefreshNodeInfo on every node after scan is complete"
-                          persistent-hint
-                          label="Refresh node info"
-                          v-model="zwave.refreshNodeInfo"
-                        ></v-switch>
-                      </v-flex>
-                      <v-flex xs12 sm6>
-                        <v-switch
-                          hint="Automatically heal network at a specific time"
-                          persistent-hint
-                          label="Auto Heal Network"
-                          v-model="zwave.healNetwork"
-                        ></v-switch>
-                      </v-flex>
-                      <v-flex xs6 sm6 v-if="zwave.healNetwork">
-                        <v-text-field
-                          v-model.number="zwave.healHour"
-                          label="Heal Time"
-                          :rules="[rules.required, rules.inRange]"
-                          required
-                          min="0"
-                          max="23"
-                          suffix=":00"
-                          hint="Select the Hour (0-23) at witch the network should heal"
-                          type="number"
-                        ></v-text-field>
-                      </v-flex>
                       <v-flex xs6>
                         <v-text-field
                           v-model.number="zwave.pollInterval"
@@ -597,9 +568,6 @@ export default {
 
           return valid || 'This field is required.'
         },
-        inRange: value => {
-          return (value >= 0 && value <= 23) || 'Insert a value between 0-23'
-        },
         validName: value => {
           return (
             !/[!@#$%^&*)(+=:,;"'\\|?{}£°§<>[\]/.\s]/g.test(value) ||